[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240716155943.GM3446@thinkpad>
Date: Tue, 16 Jul 2024 21:29:43 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise
On Tue, Jul 16, 2024 at 05:23:18PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Kconfig will ask the user twice about power sequencing: once for the QCom
> WCN power sequencing driver and then again for the PCI power control
> driver using it.
>
> Let's remove the public menuconfig entry for PCI pwrctl and instead
> default the relevant symbol to 'm' only for the architectures that
> actually need it.
>
Why can't you put it in defconfig instead?
- Mani
> Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Closes: https://lore.kernel.org/lkml/CAHk-=wjWc5dzcj2O1tEgNHY1rnQW63JwtuZi_vAZPqy6wqpoUQ@mail.gmail.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> drivers/pci/pwrctl/Kconfig | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/pci/pwrctl/Kconfig b/drivers/pci/pwrctl/Kconfig
> index f1b824955d4b..b8f289e6a185 100644
> --- a/drivers/pci/pwrctl/Kconfig
> +++ b/drivers/pci/pwrctl/Kconfig
> @@ -1,17 +1,10 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -menu "PCI Power control drivers"
> -
> config PCI_PWRCTL
> tristate
>
> config PCI_PWRCTL_PWRSEQ
> - tristate "PCI Power Control driver using the Power Sequencing subsystem"
> + tristate
> select POWER_SEQUENCING
> select PCI_PWRCTL
> default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM)
> - help
> - Enable support for the PCI power control driver for device
> - drivers using the Power Sequencing subsystem.
> -
> -endmenu
> --
> 2.43.0
>
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists