linux-kernel - Re: [PATCH v3 2/2] i2c: piix4: Register SPDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <i633av3v2a4chdh5a7yk6nv6y77ohvpajeozypjdroufikes6k@cmvpywjwj4df>
Date: Tue, 16 Jul 2024 19:46:43 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Thomas Weißschuh <linux@...ssschuh.net>, Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, 
	Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH v3 2/2] i2c: piix4: Register SPDs

Hi Thomas,

On Fri, Jul 12, 2024 at 02:53:49PM GMT, Wolfram Sang wrote:
> > Only the first 8 slots are supported. If the system has more,
> > then these will not be visible.
> > 
> > The AUX bus can not be probed as on some platforms it reports all
> > devices present and all reads return "0".
> > This would allow the ee1004 to be probed incorrectly.
> 
> I think this information would also be helpful as a comment above the
> code. But to allow this series to be applied now, I think an incremental
> patch will do. With Heiner's ack, I think this can go in now.

I agree with Wolfram here. Are you up for a v4 or do you want me
to add the comment while pushing?

Andi