linux-kernel - Re: [PATCH] of/platform: Fix inverted check in of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4edc5e10f4407c281960dad69d7f463b.sboyd@kernel.org>
Date: Tue, 16 Jul 2024 11:26:51 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org, Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] of/platform: Fix inverted check in of_platform_notify()

Quoting Geert Uytterhoeven (2024-07-16 02:57:25)
> The check for of_node_check_flag() was accidentally inverted, causing
> i2c-demux-pinctrl to fail on the Koelsch development board:
> 
>     i2c-demux-pinctrl i2c-mux1: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux2: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux3: failed to setup demux-adapter 0 (-19)
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef0000.video
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef1000.video
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-in
>     i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-out
> 
> and anything relying on I2C connected to these muxes fails, too.
> 
> Also, loading the 25LC040 DT overlay on Ebisu using the out-of-tree
> of-configfs now fails, too.
> 
> Fixes: 98290f295fbcf18f ("of/platform: Allow overlays to create platform devices from the root node")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---

Thanks. I'm going to fold this into the patch and resend the series.