linux-kernel - Re: [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <sf4fm42uqvprx4ubvuuwso4f5wjjou6peeoae3lb3fykso5gqs@jbe6unx7egtg>
Date: Tue, 16 Jul 2024 20:27:17 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4

Hi Thomas,

On Tue, Jul 09, 2024 at 07:35:34PM GMT, Thomas Weißschuh wrote:
> Patches 1 is a preparation patch.
> Patch 2 is the actual change to piix4.
> 
> Patch 1 drops the warning about muxed busses.
> I didn't feel that the warning only would warrant the additional
> complexity it introduces with multiple callers of i2c_register_spd().
> 
> If others feel different, maybe a more generic warning/info or a source
> code comment would suffice.
> 
> On a machine with 32 slots of which 16 are populated only the first 8
> slots are addressable, half of which are empty.
> Unfortunately I couldn't run a custom kernel for testing.
> But manually instantiating ee1004 devices worked as expected,
> so the proposed changes should also work.
> 
> Tested with spd5118 and two DIMMs.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

with the comment added, pushed to

i2c/i2c-host.

Thanks,
Andi