linux-kernel - Re: [PATCH] wifi: b43: Constify struct lpphy_tx_gain_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717195743.31bdb01d@barney>
Date: Wed, 17 Jul 2024 19:57:43 +0200
From: Michael Büsch <m@...s.ch>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Kalle Valo <kvalo@...nel.org>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org,
 b43-dev@...ts.infradead.org
Subject: Re: [PATCH] wifi: b43: Constify struct lpphy_tx_gain_table_entry

On Tue, 16 Jul 2024 22:21:13 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

>  static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
> -				struct lpphy_tx_gain_table_entry data)
> +				const struct lpphy_tx_gain_table_entry data)
>  {
>  	u32 tmp;
>  
> @@ -2356,7 +2356,7 @@ static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
>  }
>  
>  static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
> -				struct lpphy_tx_gain_table_entry data)
> +				const struct lpphy_tx_gain_table_entry data)
>  {
>  	u32 tmp;
>  
> @@ -2383,7 +2383,7 @@ static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
>  }
>  
>  void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
> -			    struct lpphy_tx_gain_table_entry data)
> +			    const struct lpphy_tx_gain_table_entry data)
>  {
>  	if (dev->phy.rev >= 2)
>  		lpphy_rev2plus_write_gain_table(dev, offset, data);
> @@ -2392,7 +2392,7 @@ void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
>  }

These three changes look like they are not necessary.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped