linux-kernel - Re: [PATCH] kbuild: fix rebuild of generic syscall headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3115c9ce-d7ac-47e3-91e8-65aef4826760@app.fastmail.com>
Date: Wed, 17 Jul 2024 20:51:34 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Masahiro Yamada" <masahiroy@...nel.org>,
 "Linus Torvalds" <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
 "Nathan Chancellor" <nathan@...nel.org>, "Nicolas Schier" <nicolas@...sle.eu>
Subject: Re: [PATCH] kbuild: fix rebuild of generic syscall headers

On Wed, Jul 17, 2024, at 18:24, Masahiro Yamada wrote:
> Commit fbb5c0606fa4 ("kbuild: add syscall table generation to
> scripts/Makefile.asm-headers") started to generate syscall headers
> for architectures using generic syscalls.
>
> However, these headers are always rebuilt using GNU Make 4.4.1 or newer.
>
> When using GNU Make 4.4 or older, these headers are not rebuilt when the
> command to generate them is changed, despite the use of the if_changed
> macro.
>
> scripts/Makefile.asm-headers now uses FORCE, but it is not marked as
> .PHONY. To handle the command line change correctly, .*.cmd files must
> be included.
>
> Fixes: fbb5c0606fa4 ("kbuild: add syscall table generation to 
> scripts/Makefile.asm-headers")
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Closes: 
> https://lore.kernel.org/lkml/CAHk-=wibB7SvXnUftBgAt+4-3vEKRpvEgBeDEH=i=j2GvDitoA@mail.gmail.com/
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Thanks a lot for the fix!

Tested-by: Arnd Bergmann <arnd@...db.de>