linux-kernel - Re: [EXTERNAL] Re: [PATCH v10 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <920e1e90-d72c-48e0-b7da-c2ac77128f6b@quicinc.com>
Date: Tue, 16 Jul 2024 20:55:15 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>,
        Vamsi Krishna Attunuru
	<vattunuru@...vell.com>
CC: "arnd@...db.de" <arnd@...db.de>, Jerin Jacob <jerinj@...vell.com>,
        Srujana
 Challa <schalla@...vell.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v10 1/1] misc: mrvl-cn10k-dpi: add Octeon
 CN10K DPI administrative driver

On 7/12/24 01:54, Greg KH wrote:
> On Fri, Jul 12, 2024 at 08:44:22AM +0000, Vamsi Krishna Attunuru wrote:
>>
>>>>>>>>
>>>>>>>> +config MARVELL_CN10K_DPI
>>>>>>>> +	tristate "Octeon CN10K DPI driver"
>>>>>>>> +	depends on ARM64 && PCI
>>>>>>>
>>>>>>> Why does ARM64 matter here?  I don't see any dependency required
>>> of it.
>>>>>>>
>>>>>> Thanks, Greg, for your time. This DPI device is an on-chip PCIe
>>>>>> device and only present on Marvell's CN10K platforms(which are
>>>>>> 64-bit ARM SoC
>>>>> processors), so added those dependency.
>>>>>
>>>>> Then perhaps keep the ARM64 and add a COMPILE_TEST option as well so
>>>>> that we can build this as part of normal testing?
>>>>>
>>>>> So that would be:
>>>>> 	depends on PCI && (ARM64 || COMPILE_TEST) right?
>>>>>
>>>> Yes, it makes sense to add. Can I send this fix as next version now so
>>>> that it will show up in next release, please suggest.
>>>
>>> Send it as a follow-on patch on top of my tree, doing what Arnd suggested.
>>
>> Hi Greg, I submitted the follow-on patch on top of your char-misc-testing.
>> Please let me know if there is any additional action required on my part.
> 
> Just now applied, this crossed in the email ether.
> 
> greg k-h

I'm trying to build with some legacy drivers enabled to find some 
remaining missing MODULE_DESCRIPTION() macros, and when trying to entice 
some warnings from ARCH_NETWINDER this series gave me the same errors 
flagged earlier:

drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_reg_write':
drivers/misc/mrvl_cn10k_dpi.c:190:9: error: implicit declaration of 
function 'writeq'; did you mean 'writeb'? 
[-Werror=implicit-function-declaration]
   190 |         writeq(val, dpi->reg_base + offset);
       |         ^~~~~~
       |         writeb
drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_reg_read':
drivers/misc/mrvl_cn10k_dpi.c:195:16: error: implicit declaration of 
function 'readq'; did you mean 'readb'? 
[-Werror=implicit-function-declaration]
   195 |         return readq(dpi->reg_base + offset);
       |                ^~~~~
       |                readb


Seeing these on linux-next tag: next-20240715
Will the fix reach linux-next soon?

/jeff