linux-kernel - Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz>
Date: Wed, 17 Jul 2024 22:19:19 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: akpm@...ux-foundation.org, kent.overstreet@...ux.dev, hch@...radead.org,
 pasha.tatashin@...een.com, souravpanda@...gle.com, keescook@...omium.org,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page()

On 7/17/24 10:04 PM, Suren Baghdasaryan wrote:
> On Wed, Jul 17, 2024 at 12:36 PM Vlastimil Babka <vbabka@...e.cz> wrote:
>>
>> On 7/17/24 8:12 PM, Suren Baghdasaryan wrote:
>> > Outline and export free_reserved_page() because modules use it and it
>> > in turn uses page_ext_{get|put} which should not be exported. The same
>> > result could be obtained by outlining {get|put}_page_tag_ref() but that
>> > would have higher performance impact as these functions are used in
>> > more performance critical paths.
>> >
>> > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging")
>> > Reported-by: kernel test robot <lkp@...el.com>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/
>> > Suggested-by: Christoph Hellwig <hch@...radead.org>
>> > Suggested-by: Vlastimil Babka <vbabka@...e.cz>
>> > Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
>>
>> Acked-by: Vlastimil Babka <vbabka@...e.cz>
>>
>> Are these two patches now stable@ material as 6.10 build is broken on ppc64
>> with alloc taging enabled?
> 
> I tested them with that specific configuration mentioned in the bug
> report and with several usual ones I use.
> Yeah, I guess from now on all such fixes should have
> 
> Cc: stable@...r.kernel.org # v6.10

Right. BTW I have just realized that the way you did Patch 2/2 and outlined
the whole free_reserved_page() (which is fair, it's an init-time function),
mem_alloc_profiling_enabled() didn't stay inlined so Patch 1/2 is in fact
not necessary anymore?