linux-kernel - Re: [PATCH] efi/libstub: Fixed an issue with screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGxDbALV=o+LRqB+X7ozcjfvCoGAJxihDavY=tRih8NJw@mail.gmail.com>
Date: Wed, 17 Jul 2024 13:53:54 -0700
From: Ard Biesheuvel <ardb@...nel.org>
To: Qiang Ma <maqianga@...ontech.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi/libstub: Fixed an issue with screen_info not being initialized

On Wed, 17 Jul 2024 at 00:01, Qiang Ma <maqianga@...ontech.com> wrote:
>
> After calling uefi interface allocate_pool to apply for memory, we
> should clear 0 to prevent the possibility of using random values.
>
> Signed-off-by: Qiang Ma <maqianga@...ontech.com>
> ---
>  drivers/firmware/efi/libstub/screen_info.c | 2 ++
>  1 file changed, 2 insertions(+)
>

Thanks. I've queued this as a fix.

> diff --git a/drivers/firmware/efi/libstub/screen_info.c b/drivers/firmware/efi/libstub/screen_info.c
> index a51ec201ca3c..5d3a1e32d177 100644
> --- a/drivers/firmware/efi/libstub/screen_info.c
> +++ b/drivers/firmware/efi/libstub/screen_info.c
> @@ -32,6 +32,8 @@ struct screen_info *__alloc_screen_info(void)
>         if (status != EFI_SUCCESS)
>                 return NULL;
>
> +       memset(si, 0, sizeof(*si));
> +
>         status = efi_bs_call(install_configuration_table,
>                              &screen_info_guid, si);
>         if (status == EFI_SUCCESS)
> --
> 2.20.1
>