| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <238a1132-9ae5-4a2b-8f7c-31326d5d464c@broadcom.com>
Date: Wed, 17 Jul 2024 14:06:17 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Jim Quinlan <james.quinlan@...adcom.com>, linux-pci@...r.kernel.org,
Nicolas Saenz Julienne <nsaenz@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Cyril Brulebois <kibi@...ian.org>, Stanimir Varbanov <svarbanov@...e.de>,
bcm-kernel-feedback-list@...adcom.com, jim2101024@...il.com
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/12] dt-bindings: PCI: Cleanup of brcmstb YAML and
add 7712 SoC
On 7/16/24 23:51, Krzysztof Kozlowski wrote:
> On 16/07/2024 23:31, Jim Quinlan wrote:
>> o Change order of the compatible strings to be alphabetical
>>
>> o Describe resets/reset-names before using them in rules
>>
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
Maybe the feedback was not clear, the fault cannot always be in the
submitter, right?
>
> Thank you.
> </form letter>
>
>> o Add minItems/maxItems where needed.
>>
>> o Change maintainer: Nicolas has not been active for a while. It also
>> makes sense for a Broadcom employee to be the maintainer as many of the
>> details are privy to Broadcom.
>>
>> Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
>> ---
>> .../bindings/pci/brcm,stb-pcie.yaml | 26 ++++++++++++++-----
>> 1 file changed, 19 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
>> index 11f8ea33240c..692f7ed7c98e 100644
>> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
>> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>> title: Brcmstb PCIe Host Controller
>>
>> maintainers:
>> - - Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
>> + - Jim Quinlan <james.quinlan@...adcom.com>
>>
>> properties:
>> compatible:
>> @@ -16,11 +16,11 @@ properties:
>> - brcm,bcm2711-pcie # The Raspberry Pi 4
>> - brcm,bcm4908-pcie
>> - brcm,bcm7211-pcie # Broadcom STB version of RPi4
>> - - brcm,bcm7278-pcie # Broadcom 7278 Arm
>> - brcm,bcm7216-pcie # Broadcom 7216 Arm
>> - - brcm,bcm7445-pcie # Broadcom 7445 Arm
>> + - brcm,bcm7278-pcie # Broadcom 7278 Arm
>> - brcm,bcm7425-pcie # Broadcom 7425 MIPs
>> - brcm,bcm7435-pcie # Broadcom 7435 MIPs
>> + - brcm,bcm7445-pcie # Broadcom 7445 Arm
>>
>> reg:
>> maxItems: 1
>> @@ -95,6 +95,18 @@ properties:
>> minItems: 1
>> maxItems: 3
>>
>> + resets:
>> + minItems: 1
>> + items:
>> + - description: reset for external PCIe PERST# signal # perst
>> + - description: reset for phy reset calibration # rescal
>> +
>> + reset-names:
>> + minItems: 1
>> + items:
>> + - const: perst
>> + - const: rescal
>
> There are no devices with two resets. Anyway, this does not match one of
> your variants which have first element as rescal.
Just to be clear, is the diff below what you would expect to see when
applying both patch 1 and 4 in succession, that is the reset properties
are described "generically" and the conditional section only describes
the order and values:
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 11f8ea33240c..faab7291d722 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -95,6 +95,28 @@ properties:
minItems: 1
maxItems: 3
+ resets:
+ minItems: 1
+ maxItems: 3
+ oneOf:
+ - description: reset controller handling the PERST# signal
+ - description: phandle pointing to the RESCAL reset controller
+ - items:
+ - description: phandle pointing to the RESCAL reset controller
+ - description: reset for PCIe/CPU bus bridge
+ - description: reset for soft PCIe core reset
+
+ reset-names:
+ minItems: 1
+ maxItems: 3
+ oneOf:
+ - const: perst
+ - const: rescal
+ - items:
+ - const: rescal
+ - const: bridge
+ - const: swinit
+
required:
- compatible
- reg
@@ -118,8 +140,7 @@ allOf:
then:
properties:
resets:
- items:
- - description: reset controller handling the PERST# signal
+ maxItems: 1
reset-names:
items:
@@ -136,8 +157,7 @@ allOf:
then:
properties:
resets:
- items:
- - description: phandle pointing to the RESCAL reset controller
+ maxItems: 1
reset-names:
items:
@@ -146,6 +166,22 @@ allOf:
required:
- resets
- reset-names
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: brcm,bcm7712-pcie
+ then:
+ properties:
+ resets:
+ minItems: 3
+
+ reset-names:
+ minItems: 3
+
+ required:
+ - resets
+ - reset-names
unevaluatedProperties: false
Thanks!
--
Florian
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)
Powered by blists - more mailing lists