linux-kernel - Re: [PATCH] x86/resctrl: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4197ad98-a7f7-487d-a303-d682677e0b80@wanadoo.fr>
Date: Wed, 17 Jul 2024 07:12:00 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 kernel-janitors@...r.kernel.org, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Fenghua Yu
 <fenghua.yu@...el.com>, "H. Peter Anvin" <hpa@...or.com>,
 Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH] x86/resctrl: Use seq_putc() in two functions

Le 16/07/2024 à 23:43, Reinette Chatre a écrit :
> Hi Markus,
> 
> On 7/13/24 2:00 AM, Markus Elfring wrote:
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Sat, 13 Jul 2024 10:43:14 +0200
>>
>> Single characters should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>

...

> Could you please highlight the benefit of this change? Looking at 
> seq_puts() implementation, thanks
> to [1], it seems to me these seq_puts() calls will result in seq_putc() 
> anyway?

Hi,

in this case, there is no benefit and the generated code should be 
exactly the same.

CJ

> 
> Reinette
> 
> [1] 
> https://lore.kernel.org/all/a8589bffe4830dafcb9111e22acf06603fea7132.1713781332.git.christophe.jaillet@wanadoo.fr/
> 
>