linux-kernel - Re: [PATCH] mailbox: zynqmp-ipi: Make polling period configurable from kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a7503a8-39e8-4741-b38a-40c3bc0a2ca8@amd.com>
Date: Wed, 17 Jul 2024 08:05:09 +0200
From: Michal Simek <michal.simek@....com>
To: Ben Levinsky <ben.levinsky@....com>, jassisinghbrar@...il.com,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 tanmay.shah@....com
Subject: Re: [PATCH] mailbox: zynqmp-ipi: Make polling period configurable
 from kconfig



On 7/16/24 23:50, Ben Levinsky wrote:
> The polling period for ZynqMP IPI Mailbox is currently hard-coded to
> five milliseconds. To avoid patching this when modifying the value, the
> value is now set with default that can be overwritten from kconfig
> prompt.
> 
> Signed-off-by: Ben Levinsky <ben.levinsky@....com>
> ---
>   drivers/mailbox/Kconfig              | 12 ++++++++++++
>   drivers/mailbox/zynqmp-ipi-mailbox.c |  9 ++++++++-
>   2 files changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 3b8842c4a340..c87a92400616 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -259,6 +259,18 @@ config ZYNQMP_IPI_MBOX
>   	  message to the IPI buffer and will access the IPI control
>   	  registers to kick the other processor or enquire status.
>   
> +config ZYNQMP_IPI_MBOX_POLL_PERIOD
> +	int
> +	prompt "ZynqMP IPI Mailbox driver polling period"
> +	default 5
> +	depends on ZYNQMP_IPI_MBOX
> +	help
> +	  By default the Xilinx-AMD IPI mailbox driver has a polling period
> +	  of five milliseconds. If this option is set then the provided value
> +	  will be used.
> +
> +	  Leave as default if not sure.
> +
>   config SUN6I_MSGBOX
>   	tristate "Allwinner sun6i/sun8i/sun9i/sun50i Message Box"
>   	depends on ARCH_SUNXI || COMPILE_TEST
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 4acf5612487c..df540e2b9dbe 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -64,6 +64,13 @@
>   
>   #define MAX_SGI 16
>   
> +/* Polling period in milliseconds. */
> +#ifndef CONFIG_ZYNQMP_IPI_MBOX_POLL_PERIOD
> +#define ZYNQMP_IPI_MBOX_POLL_PERIOD (5U)
> +#else
> +#define ZYNQMP_IPI_MBOX_POLL_PERIOD CONFIG_ZYNQMP_IPI_MBOX_POLL_PERIOD
> +#endif
> +

I think it would be better if this is module parameter that you don't need to 
recompile the kernel all the time when you want to change this value.

Thanks,
Michal