linux-kernel - Re: [PATCH 6.1] cifs: use origin fullpath for automounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024071751-manhandle-taunt-00ef@gregkh>
Date: Wed, 17 Jul 2024 08:26:39 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Andrew Paniakin <apanyaki@...zon.com>
Cc: stable@...r.kernel.org, Benjamin Herrenschmidt <benh@...zon.com>,
	Hazem Mohamed Abuelfotoh <abuehaze@...zon.com>,
	Paulo Alcantara <pc@...guebit.com>, Paulo Alcantara <pc@....nz>,
	Steve French <stfrench@...rosoft.com>,
	Steve French <sfrench@...ba.org>,
	Ronnie Sahlberg <lsahlber@...hat.com>,
	Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
	"open list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS and SMB3)" <linux-cifs@...r.kernel.org>,
	"moderated list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS and SMB3)" <samba-technical@...ts.samba.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6.1] cifs: use origin fullpath for automounts

On Mon, Jul 15, 2024 at 01:48:44PM +0200, Greg KH wrote:
> On Sat, Jul 13, 2024 at 03:11:47AM +0000, Andrew Paniakin wrote:
> > From: Paulo Alcantara <pc@....nz>
> > 
> > commit 7ad54b98fc1f141cfb70cfe2a3d6def5a85169ff upstream.
> > 
> > Use TCP_Server_Info::origin_fullpath instead of cifs_tcon::tree_name
> > when building source paths for automounts as it will be useful for
> > domain-based DFS referrals where the connections and referrals would
> > get either re-used from the cache or re-created when chasing the dfs
> > link.
> > 
> > Signed-off-by: Paulo Alcantara (SUSE) <pc@....nz>
> > Signed-off-by: Steve French <stfrench@...rosoft.com>
> > [apanyaki: backport to v6.1-stable]
> > Signed-off-by: Andrew Paniakin <apanyaki@...zon.com>
> > ---
> > This patch fixes issue reported in
> > https://lore.kernel.org/regressions/ZnMkNzmitQdP9OIC@3c06303d853a.ant.amazon.com
> > 
> > 1. The set_dest_addr function gets ip address differntly. In kernel 6.1
> > the dns_resolve_server_name_to_ip function returns string instead of
> > struct sockaddr, this string needs to be converted with
> > cifs_convert_address then.
> > 
> > 2. There's no tmp.leaf_fullpath field in kernel 6.1, it was introduced
> > later in a1c0d00572fc ("cifs: share dfs connections and supers")
> > 
> > 3. __build_path_from_dentry_optional_prefix and
> > dfs_get_automount_devname were added to fs/smb/client/cifsproto.h
> > instead of fs/cifs/dfs.h which doesn't exist in 6.1
> 
> Now queued up, thanks.

Nope, now dropped.  This required me to apply d5a863a153e9 ("cifs: avoid
dup prefix path in dfs_get_automount_devname()") to the tree (and
attempt to backport it myself), but that didn't work, as it caused
reported build errors as seen here:
	https://lore.kernel.org/r/aaccd8cc-2bfe-4b2e-b690-be50540f9965@gmail.com

So I'm dropping this, and the fix-up patch.  Please be careful when
sending backports that you do NOT miss additional patches that are
required as well.  I'll be glad to take backports, as long as they are
correct :)

thanks,

greg k-h