linux-kernel - Re: [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC hard-coding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0d4b7a3-2b61-3d42-a430-34b30eeaa644@quicinc.com>
Date: Wed, 17 Jul 2024 12:02:33 +0530
From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen
 Boyd <sboyd@...nel.org>
CC: <dmitry.baryshkov@...aro.org>, <stable@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC
 hard-coding


On 7/15/2024 8:29 PM, Bryan O'Donoghue wrote:
> We have both shared_ops for the Titan Top GDSC and a hard-coded always on
> whack the register and forget about it in probe().
>
> @static struct clk_branch camcc_gdsc_clk = {}
>
> Only one representation of the Top GDSC is required. Use the CCF
> representation not the hard-coded register write.
>
> Fixes: ff93872a9c61 ("clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC")
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org> # Lenovo X13s
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
>   drivers/clk/qcom/camcc-sc8280xp.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c
> index 479964f91608..f99cd968459c 100644
> --- a/drivers/clk/qcom/camcc-sc8280xp.c
> +++ b/drivers/clk/qcom/camcc-sc8280xp.c
> @@ -3031,19 +3031,14 @@ static int camcc_sc8280xp_probe(struct platform_device *pdev)
>   	clk_lucid_pll_configure(&camcc_pll6, regmap, &camcc_pll6_config);
>   	clk_lucid_pll_configure(&camcc_pll7, regmap, &camcc_pll7_config);
>   
> -	/* Keep some clocks always-on */
> -	qcom_branch_set_clk_en(regmap, 0xc1e4); /* CAMCC_GDSC_CLK */


As I mentioned on [1], this change might break the GDSC functionality. 
Hence this shouldn't be removed.


[1] 
https://lore.kernel.org/linux-clk/0b84b689-8ab8-bcdf-f058-da2ead73786c@quicinc.com/


> -
>   	ret = qcom_cc_really_probe(&pdev->dev, &camcc_sc8280xp_desc, regmap);
>   	if (ret)
> -		goto err_disable;
> +		goto err_put_rpm;
>   
>   	pm_runtime_put(&pdev->dev);
>   
>   	return 0;
>   
> -err_disable:
> -	regmap_update_bits(regmap, 0xc1e4, BIT(0), 0);


This change is required, hence can go as a separate patch.


>   err_put_rpm:
>   	pm_runtime_put_sync(&pdev->dev);
>   
>
> ---
> base-commit: 3fe121b622825ff8cc995a1e6b026181c48188db
> change-id: 20240715-linux-next-24-07-13-sc8280xp-camcc-fixes-274f11b396ac
>
> Best regards,