linux-kernel - Re: [PATCH v1 4/4] usb: typec: ucsi: Fix SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06f1b509-220e-415b-a24b-7fe8dc796328@linaro.org>
Date: Wed, 17 Jul 2024 09:56:56 +0200
From: neil.armstrong@...aro.org
To: Jameson Thies <jthies@...gle.com>, heikki.krogerus@...ux.intel.com,
 linux-usb@...r.kernel.org
Cc: bleung@...gle.com, abhishekpandit@...omium.org, andersson@...nel.org,
 dmitry.baryshkov@...aro.org, fabrice.gasnier@...s.st.com,
 gregkh@...uxfoundation.org, hdegoede@...hat.com,
 rajaram.regupathy@...el.com, saranya.gopal@...el.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 4/4] usb: typec: ucsi: Fix SET_PDR typo in UCSI header
 file

On 17/07/2024 02:49, Jameson Thies wrote:
> Fix SET_PDR typo in UCSI header file.
> 
> Signed-off-by: Jameson Thies <jthies@...gle.com>
> ---
>   drivers/usb/typec/ucsi/ucsi.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 57129f3c0814..375f1881c1e2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -152,7 +152,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
>   #define UCSI_SET_UOR_ROLE(_r_)		(((_r_) == TYPEC_HOST ? 1 : 2) << 23)
>   #define UCSI_SET_UOR_ACCEPT_ROLE_SWAPS		BIT(25)
>   
> -/* SET_PDF command bits */
> +/* SET_PDR command bits */
>   #define UCSI_SET_PDR_ROLE(_r_)		(((_r_) == TYPEC_SOURCE ? 1 : 2) << 23)
>   #define UCSI_SET_PDR_ACCEPT_ROLE_SWAPS		BIT(25)
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>