linux-kernel - Re: [PATCH 0/4] rtc: stm32: add pinctrl interface to handle RTC outs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5266d334-0006-4fa8-981d-eca04f99a899@foss.st.com>
Date: Wed, 17 Jul 2024 09:57:55 +0200
From: Valentin CARON <valentin.caron@...s.st.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>,
        <linux-rtc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Amelie Delaunay <amelie.delaunay@...s.st.com>,
        Valentin Caron
	<valentin.caron@...s.st.com>
Subject: Re: [PATCH 0/4] rtc: stm32: add pinctrl interface to handle RTC outs



On 7/15/24 23:12, Alexandre Belloni wrote:
> Hello,
> 
> On 11/07/2024 16:08:39+0200, Valentin Caron wrote:
>> This series adds a pinctrl/pinmux interface to control STM32 RTC outputs.
>>
>> Theses two signals output are possible:
>>   - LSCO (Low Speed Clock Output) that allow to output LSE clock on a pin.
>>     On STM32MPU Discovery boards, this feature is used to generate a clock
>>     to Wifi/Bluetooth module.
>>   - Alarm out that allow to send a pulse on a pin when alarm A of the RTC
>>     expires.
>>
>> First attempt [1] was based on 'st,' vendor properties, this one is based
>> on pinctrl and pinmux framework.
>>
>> As device-trees will be upstreamed separately, here is an example:
>>
>> stm32-pinctrl {
>>      rtc_rsvd_pins_a: rtc-rsvd-0 {
>>          pins {
>>              pinmux = <STM32_PINMUX('B', 2, AF1)>, /* OUT2 */
>>                       <STM32_PINMUX('I', 8, ANALOG)>; /* OUT2_RMP */
>>          };
>>      };
>> };
>>
>> stm32-rtc {
>>      pinctrl-0 = <&rtc_rsvd_pins_a &rtc_alarma_pins_a>;
>>
>>      /* Enable by foo-device */
>>      rtc_lsco_pins_a: rtc-lsco-0 {
>>          pins = "out2_rmp";
>>          function = "lsco";
>>      };
>>
>>      /* Enable by stm32-rtc hog */
>>      rtc_alarma_pins_a: rtc-alarma-0 {
>>          pins = "out2";
>>          function = "alarm-a";
>>      };
>> };
>>
>> foo-device {
>>      pinctrl-0 = <&rtc_lsco_pins_a>;
>> };
>>
> 
> This all seems good to me, I let you fix the various issues that have
> been reported. I was just wondering whether the LSCO clock was registered
> early enough to be used but I guess you tested that.
> 

Hi,

Here it is:
https://lore.kernel.org/lkml/20240717074835.2210411-1valentin.caron@foss.st.com/

Yes it works fine, RTC is probed early enough in the boot sequence, and 
so Wifi/BT module does not have an issue to get the LSCO clock.

Thanks,
Valentin