linux-kernel - Re: [PATCH 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717081057.GC3312@francesco-nb>
Date: Wed, 17 Jul 2024 10:10:57 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Francesco Dolcini <francesco@...cini.it>,
	Brian Norris <briannorris@...omium.org>,
	Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256

On Wed, Jul 17, 2024 at 08:12:16AM +0200, Sascha Hauer wrote:
> On Tue, Jul 16, 2024 at 09:57:31PM +0200, Francesco Dolcini wrote:
> > Hello Sascha,
> > 
> > On Tue, Jul 16, 2024 at 01:33:28PM +0200, Sascha Hauer wrote:
> > > This adds support for the WPA-PSK AKM suite with SHA256 as hashing
> > > method (WPA-PSK-SHA256). Tested with a wpa_supplicant provided AP
> > > using key_mgmt=WPA-PSK-SHA256.
> > 
> > Do you have any more details on which chip/firmware you tested?
> > The change looks good, I am just wondering if there are reasons this
> > might create issue on some specific chip/firmware combination.
> 
> I have a IW416 with firmware 16.92.21.p119. The change itself is derived
> from the downstream driver. The downstream driver also sets the
> KEY_MGMT_PSK_SHA256 bit unconditionally for all chip/firmware
> combinations so I think this change should be ok.

Fine for me

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>

Francesco