linux-kernel - Re: [PATCH 0/3] Add fixups for two-plane serial NAND flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240717101610.792a4a11@xps-13>
Date: Wed, 17 Jul 2024 10:16:10 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Cheng Ming Lin <linchengming884@...il.com>
Cc: vigneshr@...com, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, richard@....at, alvinzhou@...c.com.tw,
 leoyu@...c.com.tw, Cheng Ming Lin <chengminglin@...c.com.tw>
Subject: Re: [PATCH 0/3] Add fixups for two-plane serial NAND flash

Hi Cheng,

linchengming884@...il.com wrote on Wed, 10 Jul 2024 09:15:38 +0800:

> From: Cheng Ming Lin <chengminglin@...c.com.tw>
> 
> Macronix serial NAND flash with a two-plane structure
> requires insertion of Plane Select bit into the column
> address during the write_to_cache operation.
> 
> Additionally, for MX35{U,F}2G14AC, insertion of Plane
> Select bit into the column address is required during
> the read_from_cache operation.
> 
> In spinand.h, add struct spi_nand_fixups as SPI NAND
> fixup hooks.
> 
> In macronix.c, add fixup functions and update ID table.
> 
> In core.c, add an if statement to determine whether to
> insert the Plane Select bit for the column address.
> 
> These flashes have been validated on Xilinx zynq-picozed
> board which included Macronix SPI Host.
> 
> Cheng Ming Lin (3):
>   include/linux/mtd/spinand.h: Add fixups for spinand
>   mtd: spinand: macronix: Fixups for PLANE_SELECT_BIT
>   mtd: spinand: Insert Plane Select bit for the column address

I believe patches 1 and 3 should be squashed and come before patch 2.

In general in your code, please avoid camelCase.

Finally, I am not convinced yet by this implementation, I don't know
what to propose yet, but I am not particularly in favor of adding such
hooks. Can you point to a datasheet (url and page) where I could get
more information?

> 
>  drivers/mtd/nand/spi/core.c     |  7 +++++
>  drivers/mtd/nand/spi/macronix.c | 51 +++++++++++++++++++++++++++++----
>  include/linux/mtd/spinand.h     | 17 +++++++++++
>  3 files changed, 69 insertions(+), 6 deletions(-)
> 


Thanks,
Miquèl