linux-kernel - Re: My first patch: Implement InPlaceInit for Arc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mwTq4m-u0QO2tdF5Z8++xnepgtG_dALwq7ar5JOkwuVg@mail.gmail.com>
Date: Wed, 17 Jul 2024 10:52:02 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: alexmantel93@...lbox.org
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, a.hindborg@...sung.com, aliceryhl@...gle.com, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: My first patch: Implement InPlaceInit for Arc

On Wed, Jul 17, 2024 at 5:48 AM <alexmantel93@...lbox.org> wrote:
>
> This is my very first patch for Linux. I have lifted my arms up, placed my hands on my head, and tensed my non-existent abs. Punch as hard as you can! 🙂 I am happy to receive any feedback or critique, especially regarding whether these are the correct mailing lists for the patch.
>
> Over the past few weeks, I have read a lot of the kernel documentation. However, if I missed any crucial parts, please just point me to the chapters I need to read, particularly concerning the mailing list part.

They are the correct mailing lists :)

A few notes and nits:

  - I think this email you sent is intended to be the cover letter of
    the other patch. Typically, you would generate your cover letter with
    `git format-patch`, which follows some conventions, and then fill it.

    However, for a single patch, you can just put this text below the
    `---` line (i.e. before the diffstat), and that will not get committed
    into the repository.

  - Your email's From does not have your name, which is why Git decided
    to add From to the body.

  - Commits are prefixed with the subsystem/area/... You can take a
    look at other changes in the vicinity to get a feeling for what to
    write.

  - No need for an empty line between Link and Signed-off-by.

I hope that helps, thanks for the patch, and welcome!

Cheers,
Miguel