linux-kernel - Re: [PATCH 4.19 00/66] 4.19.318-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024071700-precision-basin-0e6e@gregkh>
Date: Wed, 17 Jul 2024 11:30:07 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Frank Scheiner <frank.scheiner@....de>
Cc: akpm@...ux-foundation.org, allen.lkml@...il.com, broonie@...nel.org,
	conor@...nel.org, f.fainelli@...il.com, jonathanh@...dia.com,
	linux-kernel@...r.kernel.org, linux@...ck-us.net,
	lkft-triage@...ts.linaro.org, patches@...nelci.org,
	patches@...ts.linux.dev, pavel@...x.de, rwarsow@....de,
	shuah@...nel.org, srw@...dewatkins.net, stable@...r.kernel.org,
	sudipm.mukherjee@...il.com, torvalds@...ux-foundation.org,
	Tomáš Glozar <tglozar@...il.com>
Subject: Re: [PATCH 4.19 00/66] 4.19.318-rc1 review

On Wed, Jul 17, 2024 at 10:54:40AM +0200, Frank Scheiner wrote:
> Hi there,
> 
> fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
> included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
> stays in.

I do not know what commit a589979f345720aca32ff43a2ccaa16a70871b9e is,
sorry.  If you rea referring to commits in the -rc tree, please don't as
that tree is rebased and regenerated all the time.  In fact, my scripts
don't even save a local copy when they are generated so I have no idea
how to find this :(

Please refer to the commit id in Linus's tree so I have a hint as to
what is happening here.

> ****
> 
> ## Long version ##
> 
> It looks like:
> 
> ```
> hpet: Support 32-bit userspace
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
> ```

Ah, you mean commit 4e60131d0d36 ("hpet: Support 32-bit userspace"),
right?

> ...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:
> 
> ```
> [...]
> drivers/char/hpet.c: In function 'hpet_read':
> drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
> use in this function)
>   311 |                 if (count < sizeof(compat_ulong_t))
>       |                                    ^~~~~~~~~~~~~~
> drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
> only once for each function it appears in
> [...]
> ```
> 
> ...as it uses a type not known to ia64 (and possibly other
> architectures) w/o also including:
> 
> ```
> asm-generic: Move common compat types to asm-generic/compat.h
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
> ```
> 
> The latter seems to be in mainline only since v4.20-rc1 and fixes the
> non-HP-Sim ia64 build ([2]) for me.
> 
> So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
> linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.

Ok, I'll queue this one up as well, hopefully nothing else breaks...

thanks,

greg k-h