linux-kernel - Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4943b94-3407-42a0-9273-f7948ae8c35b@amd.com>
Date: Wed, 17 Jul 2024 15:02:23 +0530
From: "Balasubrmanian, Vignesh" <vigbalas@....com>
To: Thomas Gleixner <tglx@...utronix.de>,
 "Balasubrmanian, Vignesh" <Vignesh.Balasubrmanian@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-toolchains@...r.kernel.org" <linux-toolchains@...r.kernel.org>
Cc: "mpe@...erman.id.au" <mpe@...erman.id.au>,
 "npiggin@...il.com" <npiggin@...il.com>,
 "christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
 "aneesh.kumar@...nel.org" <aneesh.kumar@...nel.org>,
 "naveen.n.rao@...ux.ibm.com" <naveen.n.rao@...ux.ibm.com>,
 "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
 "keescook@...omium.org" <keescook@...omium.org>,
 "x86@...nel.org" <x86@...nel.org>,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "Petkov, Borislav" <Borislav.Petkov@....com>,
 "George, Jini Susan" <JiniSusan.George@....com>, "matz@...e.de"
 <matz@...e.de>, "binutils@...rceware.org" <binutils@...rceware.org>,
 "jhb@...eBSD.org" <jhb@...eBSD.org>,
 "felix.willgerodt@...el.com" <felix.willgerodt@...el.com>,
 Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing
 xfeatures buffer layout info to x86 core files


On 7/13/2024 4:12 PM, Thomas Gleixner wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote:
>> diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
>> index 1fb83d477..cad37090b 100644
>> --- a/arch/x86/include/asm/elf.h
>> +++ b/arch/x86/include/asm/elf.h
>> @@ -13,6 +13,15 @@
>>   #include <asm/auxvec.h>
>>   #include <asm/fsgsbase.h>
>>
>> +struct xfeat_component {
>> +     u32 type;
>> +     u32 size;
>> +     u32 offset;
>> +     u32 flags;
>> +} __packed;
>> +
>> +_Static_assert(sizeof(struct xfeat_component)%4 == 0, "xfeat_component is not aligned");
> This struct is only used in xstate.c and asm/elf.h is not a UAPI
> header. So what's the point of declaring it in the header instead of
> xtsate.c?
>
> If this needs to provided for user space consumption, then it want's to
> be in a UAPI header, no?
Our initial idea is to pass the "struct xfeat_component" through "glibc".
is "include/uapi/linux/elf.h" proper header to add this ?

I couldn't see any proper header inside "arch/x86/include/uapi/asm/".

Please advise.


thanks,
vigneshbalu
> Thanks,
>
>          tglx