linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <442956f4-ca5b-4ff8-bc02-bcad4dce50e9@linaro.org>
Date: Wed, 17 Jul 2024 11:55:44 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>,
 gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andersson@...nel.org, quic_wcheng@...cinc.com,
 quic_kriskura@...cinc.com, linux-arm-msm@...r.kernel.org,
 linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger
 type for usb

On 17.07.2024 11:48 AM, Varadarajan Narayanan wrote:
> Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH
> instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not
> supported for SPIs and results in probe failure with -EINVAL.
> 
> Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332")
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index f58fd70be826..56304f996dbf 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -322,8 +322,8 @@ usb: usb@...8800 {
>  			reg = <0x08af8800 0x400>;
>  
>  			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>,
> -				     <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>;
> +				     <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Probably worth asking, is there a MPM/PDC on this platform?

Konrad