linux-kernel - Re: [PATCH 2/3] fbcon: Add an option to disable fbcon in panic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfqg49gj.fsf@minerva.mail-host-address-is-not-set>
Date: Wed, 17 Jul 2024 12:08:28 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Jocelyn Falempe <jfalempe@...hat.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Helge Deller <deller@....de>, "Jiri Slaby
 (SUSE)" <jirislaby@...nel.org>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Samuel Thibault <samuel.thibault@...-lyon.org>,
 Jocelyn Falempe <jfalempe@...hat.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 2/3] fbcon: Add an option to disable fbcon in panic.

Jocelyn Falempe <jfalempe@...hat.com> writes:

> This is required to avoid conflict between DRM_PANIC, and fbcon. If
> a drm device already handle panic with drm_panic, it should set
> the skip_panic field in fb_info, so that fbcon will stay quiet, and
> not overwrite the panic_screen.
>
> Signed-off-by: Jocelyn Falempe <jfalempe@...hat.com>
> ---

This makes sense to me as well.

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat