linux-kernel - Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2351895.22IY78Rhhi@somecomputer>
Date: Wed, 17 Jul 2024 12:19:39 +0200
From: Richard Weinberger <richard@...ma-star.at>
To: David Gstir <david@...ma-star.at>, sigma star Kernel Team <upstream+dcp@...ma-star.at>, James Bottomley <James.Bottomley@...senpartnership.com>, Mimi Zohar <zohar@...ux.ibm.com>, David Howells <dhowells@...hat.com>, Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, David Oberhollenzer <david.oberhollenzer@...ma-star.at>, Richard Weinberger <richard@....at>, upstream@...ma-star.at
Cc: linux-integrity@...r.kernel.org, keyrings@...r.kernel.org, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>, Jarkko Sakkinen <jarkko@...nel.org>
Subject: Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment

Am Mittwoch, 17. Juli 2024, 12:07:58 CEST schrieb Jarkko Sakkinen:
> On Wed Jul 3, 2024 at 3:53 PM EEST, David Gstir wrote:
> > The DCP trusted key type uses the wrong helper function to store
> > the blob's payload length which can lead to the wrong byte order
> > being used in case this would ever run on big endian architectures.
> >
> > Fix by using correct helper function.
> >
> > Signed-off-by: David Gstir <david@...ma-star.at>
> > Suggested-by: Richard Weinberger <richard@....at>
> 
> You cannot suggest a change that you author yourself.

Well, I suggested the change, not David.
So, I think you're implying that David's s-o-b cannot be before
the Suggested-by tag but after?

Thanks,
//richard

-- 
sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y