linux-kernel - Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D2RS0WWX03O1.2BBRF131UTSXC@iki.fi>
Date: Wed, 17 Jul 2024 14:27:28 +0300
From: "Jarkko Sakkinen" <jarkko.sakkinen@....fi>
To: "David Gstir" <david@...ma-star.at>, "Jarkko Sakkinen"
 <jarkko@...nel.org>
Cc: "sigma star Kernel Team" <upstream+dcp@...ma-star.at>, "James Bottomley"
 <James.Bottomley@...senPartnership.com>, "Mimi Zohar"
 <zohar@...ux.ibm.com>, "David Howells" <dhowells@...hat.com>, "Paul Moore"
 <paul@...l-moore.com>, "James Morris" <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>, "David Oberhollenzer"
 <david.oberhollenzer@...ma-star.at>, "Richard Weinberger" <richard@....at>,
 "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
 "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
 "linux-security-module@...r.kernel.org"
 <linux-security-module@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length
 assignment

On Wed Jul 17, 2024 at 2:03 PM EEST, David Gstir wrote:
> Jarkko,
>
> > On 17.07.2024, at 12:07, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> > 
> > On Wed Jul 3, 2024 at 3:53 PM EEST, David Gstir wrote:
> >> The DCP trusted key type uses the wrong helper function to store
> >> the blob's payload length which can lead to the wrong byte order
> >> being used in case this would ever run on big endian architectures.
> >> 
> >> Fix by using correct helper function.
> >> 
> >> Signed-off-by: David Gstir <david@...ma-star.at>
> >> Suggested-by: Richard Weinberger <richard@....at>
> > 
> > You cannot suggest a change that you author yourself.
> > 
> >> Reported-by: kernel test robot <lkp@...el.com>
> >> Closes: https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@intel.com/
> >> Fixes: 2e8a0f40a39c ("KEYS: trusted: Introduce NXP DCP-backed trusted keys")
> > 
> > Tags are in wrong order. For next round:
>
> here’s me relying on checkpatch.pl to tell me this, but it did not. :-/
> Anyways, thanks for reviewing! I’ll fix the tags and send v2.

Cool, might take over a week before response from my side but I'm sure
we get this to some rc of 6.11. I've purposely kept my 6.11 PR feature
free because the merge window was right in the middle of my holiday
:-)

BR, Jarkko