linux-kernel - Re: [PATCH] ASoC: dt-bindings: ti,pcm512x: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8eeaaffe-6c18-4449-a272-ca34a88fc731@kernel.org>
Date: Wed, 17 Jul 2024 14:10:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: ti,pcm512x: Convert to dtschema

On 17/07/2024 09:10, Animesh Agarwal wrote:
> Convert the PCM512x and TAS575x audio CODECs/amplifiers bindings to DT
> schema format. Add missing sound-dai-cells property.
> 
> Cc: Daniel Baluta <daniel.baluta@....com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> ---


> +
> +required:
> +  - compatible
> +  - reg
> +  - AVDD-supply
> +  - DVDD-supply
> +  - CPVDD-supply
> +
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - ti,tas5754
> +          - ti,tas5756
> +
> +then:
> +  properties:
> +    pll-in:

Please define properties in top-level properties list, not in
conditional. You can narrow the constraints per variant in conditional.


> +      description: GPIO pin used to connect the pll using <1> through <3>. The
> +        device will be configured for clock input on the given pll-in pin.
> +      $ref: /schemas/types.yaml#/definitions/uint32
> +      minimum: 1
> +      maximum: 3


Best regards,
Krzysztof