linux-kernel - Re: [PATCH] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <866f9ea0-b472-41eb-b5d3-59c0894b6fa6@bytedance.com>
Date: Wed, 17 Jul 2024 20:37:19 +0800
From: Chuyi Zhou <zhouchuyi@...edance.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>,
 Vishal Chourasia <vishalc@...ux.ibm.com>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
 vincent.guittot@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/fair: Remove cfs_rq::nr_spread_over and
 cfs_rq::exec_clock



在 2024/7/17 19:25, Chengming Zhou 写道:
> On 2024/7/17 19:07, Vishal Chourasia wrote:
>> On Tue, Jul 16, 2024 at 11:06:34PM +0800, Chuyi Zhou wrote:
>>> cfs_rq::nr_spread_over and cfs_rq::exec_clock are not used anymore in
>>> eevdf. Remove them from struct cfs_rq.
>>>
>>
>> nr_spread_over tracks the number of instances where the difference
>> between a scheduling entity's virtual runtime and the minimum virtual
>> runtime in the runqueue exceeds three times the scheduler latency,
>> indicating significant disparity in task scheduling.
>> Commit that removed its usage: 5e963f2bd: sched/fair: Commit to EEVDF
>>
>>
>> cfs_rq->exec_clock was used to account for time spent executing tasks.
>> Commit that removed its usage: 5d69eca542ee1 sched: Unify runtime
>> accounting across classes
>>
>>> Signed-off-by: Chuyi Zhou <zhouchuyi@...edance.com>
>>
>> Acked-by: Vishal Chourasia <vishalc@...ux.ibm.com>
> 
> Looks good to me! Maybe it's better to add these to your changelog.
> 
> Reviewed-by: Chengming Zhou <chengming.zhou@...ux.dev>
> 
> Thanks.



Thanks, will do this later.