linux-kernel - Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717-catsup-corny-def9db822c4e@spud>
Date: Wed, 17 Jul 2024 13:43:09 +0100
From: Conor Dooley <conor@...nel.org>
To: Alexandre Ghiti <alex@...ti.fr>
Cc: Alexandre Ghiti <alexghiti@...osinc.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Björn Töpel <bjorn@...osinc.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Nathan Chancellor <nathan@...nel.org>, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0

On Wed, Jul 17, 2024 at 01:41:23PM +0200, Alexandre Ghiti wrote:

> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@intel.com/
> > > Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> > If Nathan wrote the patch, you need to set him as the author of the
> > patch :)
> 
> 
> I thought I did, how should I do that then?

$ shazam 20240717-synapse-decade-a0d41bd7afce@...d
Grabbing thread from lore.kernel.org/all/20240717-synapse-decade-a0d41bd7afce@...d/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0
    + Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
  ---
  ✓ Signed: DKIM/rivosinc-com.20230601.gappssmtp.com (From: alexghiti@...osinc.com)
---
Total patches: 1
---
Applying: riscv: Allow to build only with LLVM >= 17.0.0
$ git show
commit f64f8420ca518b5dde35224cfff7ccfd14e5b496 (HEAD)
Author: Alexandre Ghiti <alexghiti@...osinc.com>
Date:   Wed Jul 17 13:17:16 2024 +0200

    riscv: Allow to build only with LLVM >= 17.0.0
    
    The following build failure happens when using LLVM < 17.0.0:
    
    kernel/sched/core.c:11873:7: error: cannot jump from this asm goto statement to one of its possible targets
    
    This is a known issue [1] so let's upgrade the minimal requirement for
    LLVM to the version 17.0.0, which is the first version to contain the
    fix.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
    Reported-by: kernel test robot <lkp@...el.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@intel.com/
    Signed-off-by: Nathan Chancellor <nathan@...nel.org>
    Signed-off-by: Alexandre Ghiti <alexghiti@...osinc.com>
    Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>


When you commited it, you needed to set --author. Just adding his
signoff is not sufficient.

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)