linux-kernel - Re: [PATCH 1/4] quota: avoid missing put_quota_format when DQUOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717130917.sbxkbgglhwq2wcrg@quack3>
Date: Wed, 17 Jul 2024 15:09:17 +0200
From: Jan Kara <jack@...e.cz>
To: Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc: Kemeng Shi <shikemeng@...weicloud.com>, jack@...e.com, mark@...heh.com,
	jlbec@...lplan.org, hughd@...gle.com, akpm@...ux-foundation.org,
	ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 1/4] quota: avoid missing put_quota_format when
 DQUOT_SUSPENDED is passed

On Tue 16-07-24 09:10:18, Joseph Qi wrote:
> 
> 
> On 7/15/24 9:05 PM, Kemeng Shi wrote:
> > Avoid missing put_quota_format when DQUOT_SUSPENDED is passed to
> > dquot_load_quota_sb.
> > 
> 
> It seems worth a 'Fixes' tag:
> Fixes: d44c57663723 ("quota: Remove BUG_ON in dquot_load_quota_sb()")
> 
> Other looks good to me. So with the above addressed, feel free to add:
> Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>

Thanks for the patch and review. I'll add the tag on commit.

								Honza

> 
> > Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> > ---
> >  fs/quota/dquot.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> > index 627eb2f72ef3..23fcf9e9d6c5 100644
> > --- a/fs/quota/dquot.c
> > +++ b/fs/quota/dquot.c
> > @@ -2408,7 +2408,7 @@ static int vfs_setup_quota_inode(struct inode *inode, int type)
> >  int dquot_load_quota_sb(struct super_block *sb, int type, int format_id,
> >  	unsigned int flags)
> >  {
> > -	struct quota_format_type *fmt = find_quota_format(format_id);
> > +	struct quota_format_type *fmt;
> >  	struct quota_info *dqopt = sb_dqopt(sb);
> >  	int error;
> >  
> > @@ -2418,6 +2418,7 @@ int dquot_load_quota_sb(struct super_block *sb, int type, int format_id,
> >  	if (WARN_ON_ONCE(flags & DQUOT_SUSPENDED))
> >  		return -EINVAL;
> >  
> > +	fmt = find_quota_format(format_id);
> >  	if (!fmt)
> >  		return -ESRCH;
> >  	if (!sb->dq_op || !sb->s_qcop ||
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR