linux-kernel - Re: [PATCH v2 1/2] KEYS: trusted: fix DCP blob payload length assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D2RUPJ5P1LXX.1T2OL2PBT2K78@kernel.org>
Date: Wed, 17 Jul 2024 16:33:39 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "David Gstir" <david@...ma-star.at>, "sigma star Kernel Team"
 <upstream+dcp@...ma-star.at>, "James Bottomley"
 <James.Bottomley@...senPartnership.com>, "Mimi Zohar"
 <zohar@...ux.ibm.com>, "David Howells" <dhowells@...hat.com>, "Paul Moore"
 <paul@...l-moore.com>, "James Morris" <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>, "Richard Weinberger" <richard@....at>, "David
 Oberhollenzer" <david.oberhollenzer@...ma-star.at>
Cc: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
 <linux-security-module@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <stable@...r.kernel.org>, "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH v2 1/2] KEYS: trusted: fix DCP blob payload length
 assignment

On Wed Jul 17, 2024 at 2:28 PM EEST, David Gstir wrote:
> The DCP trusted key type uses the wrong helper function to store
> the blob's payload length which can lead to the wrong byte order
> being used in case this would ever run on big endian architectures.
>
> Fix by using correct helper function.
>
> Cc: stable@...r.kernel.org # v6.10+
> Fixes: 2e8a0f40a39c ("KEYS: trusted: Introduce NXP DCP-backed trusted keys")
> Suggested-by: Richard Weinberger <richard@....at>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@intel.com/
> Signed-off-by: David Gstir <david@...ma-star.at>
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>

I applied the patches, will send the PR later on (probably either
-rc2 or -rc3), so thus they are mirrored already to also linux-next.

BR, Jarkko