linux-kernel - Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240717-pardon-sake-56850ddca236@spud>
Date: Wed, 17 Jul 2024 15:33:51 +0100
From: Conor Dooley <conor@...nel.org>
To: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Dimitri Fedrau <dima.fedrau@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	Nuno Sá <noname.nuno@...il.com>
Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml

On Wed, Jul 17, 2024 at 01:07:31AM +0000, Paller, Kim Seer wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@...nel.org>
> > Sent: Tuesday, July 16, 2024 11:58 PM
> > To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> > Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org;
> > devicetree@...r.kernel.org; Jonathan Cameron <jic23@...nel.org>; David
> > Lechner <dlechner@...libre.com>; Lars-Peter Clausen <lars@...afoo.de>;
> > Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> > Dimitri Fedrau <dima.fedrau@...il.com>; Krzysztof Kozlowski
> > <krzk+dt@...nel.org>; Rob Herring <robh@...nel.org>; Conor Dooley
> > <conor+dt@...nel.org>; Hennerich, Michael
> > <Michael.Hennerich@...log.com>; Nuno Sá <noname.nuno@...il.com>
> > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > 
> > [External]
> > 
> > On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Conor Dooley <conor@...nel.org>
> > > > Sent: Tuesday, July 16, 2024 12:18 AM
> > > > To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> > > > Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org;
> > > > devicetree@...r.kernel.org; Jonathan Cameron <jic23@...nel.org>; David
> > > > Lechner <dlechner@...libre.com>; Lars-Peter Clausen <lars@...afoo.de>;
> > > > Liam Girdwood <lgirdwood@...il.com>; Mark Brown
> > <broonie@...nel.org>;
> > > > Dimitri Fedrau <dima.fedrau@...il.com>; Krzysztof Kozlowski
> > > > <krzk+dt@...nel.org>; Rob Herring <robh@...nel.org>; Conor Dooley
> > > > <conor+dt@...nel.org>; Hennerich, Michael
> > > > <Michael.Hennerich@...log.com>; Nuno Sá <noname.nuno@...il.com>
> > > > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > > >
> > > > [External]
> > > >
> > > > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > > > > Add documentation for ltc2664.
> > > > >
> > > > > Co-developed-by: Michael Hennerich <michael.hennerich@...log.com>
> > > > > Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> > > > > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > > >
> > > > IIRC I gave you a reviewed-by on v5, was there a particular reason you
> > didn't
> > > > add it?
> > >
> > > I made changes to the 'output-range-microvolt' logic in v6, which I thought
> > > might require a new review. If your 'Reviewed-by' tag still applies, please let
> > me know.
> > 
> > IIRC what I said was along the lines of "with the logic from the
> > previous version, Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>".
> > Is that what you did?
> 
> Yes. Additionally, considering Krzysztof's recent comment about the mixed 
> indentation in the example section, should I send a new patch version that
> includes this indentation fix along with adding your Reviewed-by tag?

Seems reasonable to me, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)