linux-kernel - Re: [PATCH v2 1/7] arm/virt: place power button pin number on a define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717163442.00002b78@Huawei.com>
Date: Wed, 17 Jul 2024 16:34:42 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC: "Michael S. Tsirkin" <mst@...hat.com>, Shiju Jose <shiju.jose@...wei.com>,
	Ani Sinha <anisinha@...hat.com>, Igor Mammedov <imammedo@...hat.com>, Peter
 Maydell <peter.maydell@...aro.org>, "Shannon Zhao"
	<shannon.zhaosl@...il.com>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <qemu-arm@...gnu.org>,
	<qemu-devel@...gnu.org>
Subject: Re: [PATCH v2 1/7] arm/virt: place power button pin number on a
 define

On Fri, 12 Jul 2024 15:15:08 +0200
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:

> Having magic numbers inside the code is not a good idea, as it
> is error-prone. So, instead, create a macro with the number
> definition.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Seems sensible to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>