| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ad37b8be-4f41-45b9-a0e8-b86de53b5cec@lechnology.com>
Date: Wed, 17 Jul 2024 10:54:54 -0500
From: David Lechner <david@...hnology.com>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Herve Codina <herve.codina@...tlin.com>,
Christopher Cordahi <christophercordahi@...ometrics.ca>
Subject: Re: [PATCH] clk: davinci: da8xx-cfgchip: Initialize clk_init_data
before use
On 7/17/24 9:46 AM, Bastien Curutchet wrote:
> Hi David,
>
> On 7/17/24 16:22, David Lechner wrote:
>> On 7/17/24 9:12 AM, Bastien Curutchet wrote:
>>> The flag attribute of the struct clk_init_data isn't initialized before
>>> the devm_clk_hw_register() call. This can lead to unexpected behavior
>>> during registration.
>>>
>>> Initialize the entire clk_init_data to zero at declaration.
>>>
>>
>> Probably should add a Fixes: tag.
>>
>
> Sorry I forgot about it, that would be :
>
> Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks")
>
>
> Do I need to send a new iteration with it ?
That's ultimately up to Stephen, I guess, since he is usually the one
picking up the patches. But I think it wouldn't hurt if you did.
>
>>> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>
>>> ---
>>
>> Reviewed-by: David Lechner <david@...hnology.com>
>>
>>
>
> Best regards,
> Bastien
Powered by blists - more mailing lists