linux-kernel - Re: [PATCH v3 0/2] efi/x86: Call set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB0217E3B4810704C504F13F2CB8A32@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 17 Jul 2024 16:35:15 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Ard Biesheuvel <ardb+git@...gle.com>
CC: "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ard Biesheuvel
	<ardb@...nel.org>, Hans de Goede <hdegoede@...hat.com>, Lukas Wunner
	<lukas@...ner.de>, Kerem Karabay <kekrby@...il.com>, Orlando Chamberlain
	<orlandoch.dev@...il.com>, "sharpenedblade@...ton.me"
	<sharpenedblade@...ton.me>
Subject: Re: [PATCH v3 0/2] efi/x86: Call set_os() protocol on dual GPU Macs

Hi Ard, Lukas

Although the patch has been upstreamed, and works well for the Macs included,
we have noticed another issue. For the Macs having a single GPU, in case a person
uses an eGPU, they still need this apple-set-os quirk for hybrid graphics. This was
not reported that time by anyone since people who use an eGPU are quite rare.

I'm not sure how to handle this. Had a few ideas like:

1. Enable this for all T2 Macs.
2. Enable this for all Macs.
3. Add a kernel parameter.

Would like your ideas and a possible fix for the same.

Thanks
Aditya

> On 2 Jul 2024, at 1:12 AM, Aditya Garg <gargaditya08@...e.com> wrote:
> 
> Tested-by: Aditya Garg <gargaditya08@...e.com>
> 
> Thanks for the support Ard :)
> 
>> On 1 Jul 2024, at 7:40 PM, Ard Biesheuvel <ardb+git@...gle.com> wrote:
>> 
>> From: Ard Biesheuvel <ardb@...nel.org>
>> 
>> v3:
>> - add patch to make the SMBIOS protocol glue code compatible with mixed
>> mode on x86
>> - update Aditya's patch to limit the effect to dual GPU Macs that are
>> known to require the set_os() calls in order for both GPUs to remain
>> active after boot
>> - drop mixed mode handling of set_os() protocol, and dereference the
>> struct members directly
>> 
>> Cc: Aditya Garg <gargaditya08@...e.com>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>> Cc: Lukas Wunner <lukas@...ner.de>
>> Cc: Kerem Karabay <kekrby@...il.com>
>> Cc: Orlando Chamberlain <orlandoch.dev@...il.com>
>> 
>> Aditya Garg (1):
>> x86/efistub: Call Apple set_os protocol on dual GPU Intel Macs
>> 
>> Ard Biesheuvel (1):
>> efistub/x86: Enable SMBIOS protocol handling for x86
>> 
>> drivers/firmware/efi/libstub/Makefile   |  2 +-
>> drivers/firmware/efi/libstub/smbios.c   | 42 ++++++++----
>> drivers/firmware/efi/libstub/x86-stub.c | 72 +++++++++++++++++++-
>> include/linux/efi.h                     |  1 +
>> 4 files changed, 98 insertions(+), 19 deletions(-)
>> 
>> --
>> 2.45.2.803.g4e1b14247a-goog
>>