linux-kernel - Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240717-gracious-canning-6ff715cd1b1f@spud>
Date: Wed, 17 Jul 2024 17:39:23 +0100
From: Conor Dooley <conor@...nel.org>
To: Fabio Estevam <festevam@...il.com>
Cc: Otavio Salvador <otavio.salvador@...ystems.com.br>,
	Heiko Stübner <heiko@...ech.de>,
	linux-kernel@...r.kernel.org,
	Otavio Salvador <otavio@...ystems.com.br>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Huacai Chen <chenhuacai@...nel.org>,
	WANG Xuerui <kernel@...0n.name>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, imx@...ts.linux.dev,
	loongarch@...ts.linux.dev
Subject: Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC
 from elgin-r1

On Wed, Jul 17, 2024 at 12:34:03PM -0300, Fabio Estevam wrote:
> On Wed, Jul 17, 2024 at 11:38 AM Otavio Salvador
> <otavio.salvador@...ystems.com.br> wrote:
> 
> > @Fabio Estevam can you check this patch?
> 
> Correct, the rv1108-elgin-r1.dts board does not contain the DAC.
> 
> There is an LCD controlled via spidev though.
> 
> Conor,
> 
> If spidev is needed, what is the recommended way to describe it in the
> devicetree?

Describe the device you actually have in a binding, and add that
compatible to the spidev driver. In this case, given there's a
particular LCD there, that'll work. There's nothing wrong with using
spidev, it's just lying about what hardware that is there that's
problematic.

Otherwise, when it is an open connector where you can put anything, it's
a wee bit messier... A connector binding is required then, something
like the WIP mikrobus stuff that the beagle lads are working on. That's
far from ready, at least on the devicetree side of things, though so
you need to apply an overlay in your bootloader in that case.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)