linux-kernel - Re: [PATCH net-next v17 10/14] net: macb: Convert to netdev_ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfe37e57-bdd7-4870-b453-b83ee977b8a8@intel.com>
Date: Wed, 17 Jul 2024 10:24:01 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Kory Maincent <kory.maincent@...tlin.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>, Heiner
 Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David
 S. Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, Richard
 Cochran <richardcochran@...il.com>, "Radu Pirea"
	<radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>, Willem de Bruijn
	<willemdebruijn.kernel@...il.com>, Jonathan Corbet <corbet@....net>, Horatiu
 Vultur <horatiu.vultur@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Simon
 Horman <horms@...nel.org>, "Vladimir Oltean" <vladimir.oltean@....com>,
	<donald.hunter@...il.com>, <danieller@...dia.com>, <ecree.xilinx@...il.com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, Maxime Chevallier
	<maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Willem de Bruijn <willemb@...gle.com>, Shannon Nelson
	<shannon.nelson@....com>, Alexandra Winter <wintera@...ux.ibm.com>
Subject: Re: [PATCH net-next v17 10/14] net: macb: Convert to
 netdev_ptp_clock_register



On 7/9/2024 6:53 AM, Kory Maincent wrote:
> The hardware registration clock for net device is now using
> netdev_ptp_clock_register to save the net_device pointer within the ptp
> clock xarray. Convert the macb driver to the new API.
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> 
> Change in v8:
> - New patch
> ---
>  drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index a63bf29c4fa8..50fa62a0ddc5 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -332,7 +332,7 @@ void gem_ptp_init(struct net_device *dev)
>  	bp->tsu_rate = bp->ptp_info->get_tsu_rate(bp);
>  	bp->ptp_clock_info.max_adj = bp->ptp_info->get_ptp_max_adj();
>  	gem_ptp_init_timer(bp);
> -	bp->ptp_clock = ptp_clock_register(&bp->ptp_clock_info, &dev->dev);
> +	bp->ptp_clock = netdev_ptp_clock_register(&bp->ptp_clock_info, dev);
>  	if (IS_ERR(bp->ptp_clock)) {
>  		pr_err("ptp clock register failed: %ld\n",
>  			PTR_ERR(bp->ptp_clock));
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>