linux-kernel - Re: [PATCH] bcachefs: WARNING in bch2_fs_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6lmsdtntfs3ot4jc2waizihayhipszr3iuro3tzyjgbfvjwuw@ms4foq466yiz>
Date: Thu, 18 Jul 2024 18:45:53 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Camila Alvarez Inostroza <cam.alvarez.i@...il.com>
Cc: syzbot+4093905737cf289b6b38@...kaller.appspotmail.com, 
	Brian Foster <bfoster@...hat.com>, linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] bcachefs: WARNING in bch2_fs_journal_stop

On Thu, Jul 18, 2024 at 06:42:55PM GMT, Camila Alvarez Inostroza wrote:
> 
> 
> On Thu, 18 Jul 2024, Kent Overstreet wrote:
> 
> > On Wed, Jul 17, 2024 at 06:02:39PM GMT, Camila Alvarez wrote:
> > > last_seq and last_empty_seq suffered from an off by one error when the
> > > journal has no entries.
> > > 
> > > The indexes were fixed and an assertion is added to check that the
> > > last_empty_seq is always kept under the next valid seq number.
> > 
> > oh nice. I'm going to need to stare at this some more, I still feel like
> > this code needs to be clearer and less fiddly.
> > 
> Sure! Please let me know if there's anything I can do to help.

I'm just applying it - the warning you added gave me warm fuzzies.

I'll let you know if anything pops up in the CI (and I should give you
an account so you can point it at your own branches; email me a username
and ssh key)