linux-kernel - Re: [PATCH] iommu/amd: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae7e415d-0e70-4d84-82e3-d6827f931565@amd.com>
Date: Thu, 18 Jul 2024 10:20:59 +0700
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@....com>
To: Chen Ni <nichen@...as.ac.cn>, joro@...tes.org, will@...nel.org,
 robin.murphy@....com
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: Convert comma to semicolon

On 7/16/2024 2:25 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: c9b258c6be09 ("iommu/amd: Prepare for generic IO page table framework")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/iommu/amd/io_pgtable.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
> index 9d9a7fde59e7..1074ee25064d 100644
> --- a/drivers/iommu/amd/io_pgtable.c
> +++ b/drivers/iommu/amd/io_pgtable.c
> @@ -588,9 +588,9 @@ static struct io_pgtable *v1_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>   {
>   	struct amd_io_pgtable *pgtable = io_pgtable_cfg_to_data(cfg);
>   
> -	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES,
> -	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE,
> -	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES;
> +	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE;
> +	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE;
>   	cfg->tlb            = &v1_flush_ops;
>   
>   	pgtable->iop.ops.map_pages    = iommu_v1_map_pages;

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>

Thanks,
Suravee