[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c362839138bdd5e85809ca1297e88938f101c46c.camel@mediatek.com>
Date: Thu, 18 Jul 2024 03:26:44 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "mchehab@...nel.org" <mchehab@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
Andy Hsieh (謝智皓) <Andy.Hsieh@...iatek.com>,
"jstephan@...libre.com" <jstephan@...libre.com>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "laurent.pinchart@...asonboard.com"
<laurent.pinchart@...asonboard.com>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"paul.elder@...asonboard.com" <paul.elder@...asonboard.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "fsylvestre@...libre.com"
<fsylvestre@...libre.com>, "pnguyen@...libre.com" <pnguyen@...libre.com>
Subject: Re: [PATCH v5 4/5] media: platform: mediatek: isp_30: add mediatek
ISP3.0 camsv
Hi, Julien:
On Thu, 2024-07-04 at 15:36 +0200, Julien Stephan wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> From: Phi-bang Nguyen <pnguyen@...libre.com>
>
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
>
> Signed-off-by: Phi-bang Nguyen <pnguyen@...libre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre@...libre.com>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder@...asonboard.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Co-developed-by: Julien Stephan <jstephan@...libre.com>
> Signed-off-by: Julien Stephan <jstephan@...libre.com>
> ---
[snip]
> +#define IMG_MAX_WIDTH5376U
> +#define IMG_MAX_HEIGHT4032U
> +#define IMG_DEF_WIDTH1920U
> +#define IMG_DEF_HEIGHT1080U
>
Why do you define default width/height? Does 1920x1080 have any
benefit? If so, add comment to describe why choose 1920x1080. If no, I
think using IMG_MAX_WIDTH/IMG_MAX_HEIGHT as default is a good choice
because we could drop this redundant definition and let hardware work
in its best quality.
Regards,
CK
Powered by blists - more mailing lists