linux-kernel - Re: [PATCH v2] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a2efbd7-075c-2a93-0ea7-51566362f17e@amd.com>
Date: Thu, 18 Jul 2024 08:58:48 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Chuyi Zhou <zhouchuyi@...edance.com>, <mingo@...hat.com>,
	<peterz@...radead.org>, <juri.lelli@...hat.com>, <vincent.guittot@...aro.org>
CC: <chengming.zhou@...ux.dev>, <linux-kernel@...r.kernel.org>, Vishal
 Chourasia <vishalc@...ux.ibm.com>
Subject: Re: [PATCH v2] sched/fair: Remove cfs_rq::nr_spread_over and
 cfs_rq::exec_clock

Hello Chuyi,

On 7/17/2024 8:03 PM, Chuyi Zhou wrote:
> nr_spread_over tracks the number of instances where the difference
> between a scheduling entity's virtual runtime and the minimum virtual
> runtime in the runqueue exceeds three times the scheduler latency,
> indicating significant disparity in task scheduling.
> Commit that removed its usage: 5e963f2bd: sched/fair: Commit to EEVDF

scripts/checkpatch.pl complains about the commit description style here.
The above can be reworded as:

Commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") removed its usage.

> 
> cfs_rq->exec_clock was used to account for time spent executing tasks.
> Commit that removed its usage: 5d69eca542ee1 sched: Unify runtime
> accounting across classes

And this as:

Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
removed its usage.

> 
> cfs_rq::nr_spread_over and cfs_rq::exec_clock are not used anymore in
> eevdf. Remove them from struct cfs_rq.
> 
> Signed-off-by: Chuyi Zhou <zhouchuyi@...edance.com>
> Acked-by: Vishal Chourasia <vishalc@...ux.ibm.com>
> Reviewed-by: Chengming Zhou <chengming.zhou@...ux.dev>

Apart from those nits,

Reviewed-by: K Prateek Nayak <kprateek.nayak@....com>

-- 
Thanks and Regards,
Prateek

> ---
>   kernel/sched/debug.c | 4 ----
>   kernel/sched/sched.h | 6 ------
>   2 files changed, 10 deletions(-)
> 
> [..snip..]