linux-kernel - Re: [PATCH v2 1/3] dt-bindings: arm: rockchip: Add Firefly Core-PX30-JD4 with baseboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c804e9a0227904b16bfb779f2009af1@manjaro.org>
Date: Thu, 18 Jul 2024 06:36:16 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Christopher Obbard <chris.obbard@...labora.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, Kever Yang
 <kever.yang@...k-chips.com>, Collabora Kernel Mailing List
 <kernel@...labora.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: rockchip: Add Firefly
 Core-PX30-JD4 with baseboard

Hello Christopher,

On 2024-07-17 18:46, Christopher Obbard wrote:
> Add binding for the Firefly Core-PX30-JD4 SoM when used in conjunction
> with the MB-JD4-RK3328 & PX30 baseboard.
> 
> Signed-off-by: Christopher Obbard <chris.obbard@...labora.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf5..33ca8028bc151 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -148,6 +148,12 @@ properties:
>            - const: engicam,px30-core
>            - const: rockchip,px30
> 
> +      - description: Firefly Core-PX30-JD4 with MB-JD4-PX30 baseboard
> +        items:
> +          - const: firefly,px30-mb-jd4
> +          - const: firefly,px30-core-jd4

Similarly to how I suggested the new dts(i) files to be named, [1]
the model names should be named like this:

           - const: firefly,px30-jd4-core
           - const: firefly,px30-jd4-core-mb

This would also follow the "inheritance graph" pattern, so to speak.

[1] 
https://lore.kernel.org/linux-rockchip/38d7b7e9ab71bf1b0817e666f4233b9e@manjaro.org/

> +          - const: rockchip,px30
> +
>        - description: Firefly Firefly-RK3288
>          items:
>            - enum: