linux-kernel - Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024071845-grumble-borough-13b4@gregkh>
Date: Thu, 18 Jul 2024 07:07:00 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Vamsi Attunuru <vattunuru@...vell.com>, arnd@...db.de,
	linux-kernel@...r.kernel.org, nathan@...nel.org
Subject: Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for
 32-bit systems

On Thu, Jul 18, 2024 at 07:05:37AM +0200, Greg KH wrote:
> On Wed, Jul 17, 2024 at 10:50:25AM -0700, Jeff Johnson wrote:
> > On 7/17/24 09:37, Vamsi Attunuru wrote:
> > > Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> > > compilation errors arise on 32-bit ARM with writeq() & readq() calls
> > > which are used for accessing 64-bit values.
> > > 
> > > Since DPI hardware only works with 64-bit register accesses, using
> > > CONFIG_64BIT dependency to skip compilation on 32-bit systems.
> > > 
> > > Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> > > Signed-off-by: Vamsi Attunuru <vattunuru@...vell.com>
> > > Tested-by: Nathan Chancellor <nathan@...nel.org>
> > > Tested-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> > > ---
> > >   drivers/misc/Kconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index f3bb75384627..41c3d2821a78 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -588,7 +588,7 @@ config NSM
> > >   config MARVELL_CN10K_DPI
> > >   	tristate "Octeon CN10K DPI driver"
> > >   	depends on PCI
> > > -	depends on ARCH_THUNDER || COMPILE_TEST
> > > +	depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> > >   	help
> > >   	  Enables Octeon CN10K DMA packet interface (DPI) driver which
> > >   	  intializes DPI hardware's physical function (PF) device's
> > 
> > 
> > BTW it looks like you accidentally submitted Makefile.rej, can you submit a
> > patch to remove it?
> 
> That was me, not Vamsi, and should now be gone from the tree, sorry
> about that.

Oops, forgot to push out my local tree, should show up now, sorry about
that.

greg k-h