linux-kernel - Re: [PATCH 2/2] gpio: davinci: handle wakeup-source property, detect wake IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240718053510.ywdv5c7fk3natknl@dhruva>
Date: Thu, 18 Jul 2024 11:05:10 +0530
From: Dhruva Gole <d-gole@...com>
To: Kevin Hilman <khilman@...libre.com>
CC: <linux-gpio@...r.kernel.org>, Keerthy <j-keerthy@...com>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: davinci: handle wakeup-source property, detect
 wake IRQs

On Jul 17, 2024 at 17:09:33 -0700, Kevin Hilman wrote:
> If the wakeup-source property is used for the GPIO controller, then
> mark the controller as wakeup capable.
> 
> Further, if there are any GPIO IRQs that are marked as wakeup-enabled,
> then mark the GPIO controller as wakeup enabled also.  Since the GPIO
> IRQs that are wake-enabled are dynamic, this is (re)calculated during
> each suspend (and cleared on resume.)
> 
> Signed-off-by: Kevin Hilman <khilman@...libre.com>
> ---
>  drivers/gpio/gpio-davinci.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 1d0175d6350b..031aa7c30855 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/gpio/driver.h>
> +#include <linux/gpio/consumer.h>

Please sort this...

[...]

With that taken care,
Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva