linux-kernel - Re: [PATCH 2/2] selftests: x86: vdso_restorer: Return correct exit statuses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3724b03d-5d19-4b7d-bc5b-80e2debecbc1@collabora.com>
Date: Thu, 18 Jul 2024 12:18:34 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 "Chang S . Bae" <chang.seok.bae@...el.com>,
 Binbin Wu <binbin.wu@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] selftests: x86: vdso_restorer: Return correct exit
 statuses

On 7/17/24 3:01 AM, Shuah Khan wrote:
> On 7/12/24 01:30, Muhammad Usama Anjum wrote:
>> Return correct exit status, KSFT_SKIP if the pre-conditions aren't met.
>> Return KSFT_FAIL if error occurs. Use ksft_finished() which will
>> compmare the total planned tests with passed tests to return the exit
>> value.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> 
> Same comment - here. Include before and after output to show
> how this change improves the report.
Following results have been generated in the case when both tests fail:

# selftests: x86: vdso_restorer_32
# ERROR: ld.so: object '/usr/libexec/coreutils/libstdbuf.so' from
LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS64): ignored.
# [RUN]	Raise a signal, SA_SIGINFO, sa.restorer == NULL
# [FAIL]	SA_SIGINFO handler was not called
# [RUN]	Raise a signal, !SA_SIGINFO, sa.restorer == NULL
# [FAIL]	!SA_SIGINFO handler was not called
not ok 21 selftests: x86: vdso_restorer_32 # exit=2

# selftests: x86: vdso_restorer_32
# ERROR: ld.so: object '/usr/libexec/coreutils/libstdbuf.so' from
LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS64): ignored.
# TAP version 13
# 1..2
# [RUN]	Raise a signal, SA_SIGINFO, sa.restorer == NULL
# not ok 1 SA_SIGINFO handler returned
# [RUN]	Raise a signal, !SA_SIGINFO, sa.restorer == NULL
# not ok 2 SA_SIGINFO handler returned
# # Totals: pass:0 fail:2 xfail:0 xpass:0 skip:0 error:0
not ok 21 selftests: x86: vdso_restorer_32 # exit=1

Please let me know what you think?
> 
> thanks,
> -- Shuah
> 
> 

-- 
BR,
Muhammad Usama Anjum