linux-kernel - Re: ld.lld: error: undefined symbol: iosf_mbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmljw485.wl-tiwai@suse.de>
Date: Thu, 18 Jul 2024 09:26:18 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
	kernel test robot <lkp@...el.com>,
	llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
	Bard Liao <bard.liao@...el.com>
Subject: Re: ld.lld: error: undefined symbol: iosf_mbi_available

On Wed, 17 Jul 2024 22:28:06 +0200,
Nathan Chancellor wrote:
> 
> On Wed, Jul 17, 2024 at 01:43:35PM +0200, Pierre-Louis Bossart wrote:
> > 
> > 
> > On 7/16/24 01:07, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   3e7819886281e077e82006fe4804b0d6b0f5643b
> > > commit: 8d4ba1be3d2257606e04aff412829d8972670750 ASoC: SOF: pci: split PCI into different drivers
> > > date:   3 years, 4 months ago
> > 
> > This doesn't seem to be a problem on the latest code? was it intentional
> > to report a problem on such an old commit?
> 
> It's still reproducible at commit 8b0f0bb27c32 ("Merge tag
> 'fs_for_v6.11-rc1' of
> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs") for me,
> using either LLVM or GCC with the configuration linked below:
> 
>   ld.lld: error: undefined symbol: iosf_mbi_available
>   >>> referenced by atom.c
>   >>>               sound/soc/sof/intel/atom.o:(atom_machine_select) in archive vmlinux.a
> 
>   ld.lld: error: undefined symbol: iosf_mbi_read
>   >>> referenced by atom.c
>   >>>               sound/soc/sof/intel/atom.o:(atom_machine_select) in archive vmlinux.a
> 
>   .../gcc/14.1.0/bin/i386-linux-ld: sound/soc/sof/intel/atom.o: in function `atom_machine_select':
>   atom.c:(.text+0x1b9): undefined reference to `iosf_mbi_available'
>   .../gcc/14.1.0/bin/i386-linux-ld: atom.c:(.text+0x1e3): undefined reference to `iosf_mbi_read'

Yours looks different from the original report, and indeed this must
be a missing fix.

Does the following change cover it?


thanks,

Takashi

--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -19,6 +19,7 @@ config SND_SOC_SOF_INTEL_ATOM_HIFI_EP
 	tristate
 	select SND_SOC_SOF_INTEL_COMMON
 	select SND_SOC_SOF_INTEL_HIFI_EP_IPC
+	select IOSF_MBI if X86 && PCI
 	help
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
@@ -44,7 +45,6 @@ config SND_SOC_SOF_BAYTRAIL
 	select SND_SOC_SOF_INTEL_COMMON
 	select SND_SOC_SOF_INTEL_ATOM_HIFI_EP
 	select SND_SOC_SOF_ACPI_DEV
-	select IOSF_MBI if X86 && PCI
 	help
 	  This adds support for Sound Open Firmware for Intel(R) platforms
 	  using the Baytrail, Braswell or Cherrytrail processors.