linux-kernel - Re: [PATCH] clk: sophgo: clk-sg2042-pll: Fix uninitialized variable in debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2822E6317E7167B69BCD75EFFEAC2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 18 Jul 2024 16:48:15 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Inochi Amaoto <inochiama@...look.com>,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] clk: sophgo: clk-sg2042-pll: Fix uninitialized variable
 in debug output


On 2024/7/18 10:25, Dan Carpenter wrote:
> If sg2042_get_pll_ctl_setting() fails then "value" isn't initialized and
> it is printed in the debug output.  Initialize it to zero.
>
> Fixes: 48cf7e01386e ("clk: sophgo: Add SG2042 clock driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/clk/sophgo/clk-sg2042-pll.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sophgo/clk-sg2042-pll.c b/drivers/clk/sophgo/clk-sg2042-pll.c
> index aa142897aa5e..24b0eab6154b 100644
> --- a/drivers/clk/sophgo/clk-sg2042-pll.c
> +++ b/drivers/clk/sophgo/clk-sg2042-pll.c
> @@ -387,7 +387,7 @@ static int sg2042_clk_pll_set_rate(struct clk_hw *hw,
>   	struct sg2042_pll_clock *pll = to_sg2042_pll_clk(hw);
>   	struct sg2042_pll_ctrl pctrl_table;
>   	unsigned long flags;
> -	u32 value;
> +	u32 value = 0;
>   	int ret;
>   
>   	spin_lock_irqsave(pll->lock, flags);

Reviewed-by: Chen Wang <unicorn_wang@...look.com>

Thank you Dan.

Regards,

Chen