linux-kernel - Re: [PATCH v3 0/4] Do device node auto cleanup in drivers/soc/ti/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240718112134.txuimtlg62375jaw@musky>
Date: Thu, 18 Jul 2024 06:21:34 -0500
From: Nishanth Menon <nm@...com>
To: Kousik Sanagavarapu <five231003@...il.com>
CC: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Santosh Shilimkar
	<ssantosh@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Julia Lawall
	<julia.lawall@...ia.fr>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Javier
 Carrasco <javier.carrasco.cruz@...il.com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 0/4] Do device node auto cleanup in drivers/soc/ti/

On 03:04-20240718, Kousik Sanagavarapu wrote:
> On Sun, Jul 07, 2024 at 10:44:15AM +0530, Kousik Sanagavarapu wrote:
> > Do "struct device_node" auto cleanup in soc/ti/.  This patch series takes
> > care of all the cases where this is possible.
> > 
> > Thanks Jonathan for the review on the previous round.
> > 
> > v2:
> > 
> > 	https://lore.kernel.org/linux-arm-kernel/20240703065710.13786-1-five231003@gmail.com/
> > 
> > Changes since v2:
> > - Split v2 1/3 into v3 1/4 and v3 2/4.  The memory setup code is
> >   seperated out of the pruss_probe() function and put into 1/4 and the
> >   actual conversion to auto cleanup is done in 2/4.
> > - Replace dev_err() with dev_err_probe() in the code paths touched.
> > 
> > v1:
> > 
> > 	https://lore.kernel.org/linux-arm-kernel/20240510071432.62913-1-five231003@gmail.com/
> > 
> > Changes since v1:
> > - Refactor code so that it the scope of the pointers touched is reduced,
> >   making the code look more clean.
> > - The above also the side-effect of fixing the errors that clang emitted
> >   (but my local version of gcc didn't) for PATCH 2/3 during v1.
> > 
> > Kousik Sanagavarapu (4):
> >   soc: ti: pruss: factor out memories setup
> >   soc: ti: pruss: do device_node auto cleanup
> >   soc: ti: knav_qmss_queue: do device_node auto cleanup
> >   soc: ti: pm33xx: do device_node auto cleanup
> > 
> >  drivers/soc/ti/knav_qmss_queue.c | 100 +++++++++---------
> >  drivers/soc/ti/pm33xx.c          |  52 ++++-----
> >  drivers/soc/ti/pruss.c           | 176 ++++++++++++++-----------------
> >  3 files changed, 155 insertions(+), 173 deletions(-)
> 
> Ping

Umm... ping for what? for whom and why? In addition to reviews, I will
need someone to do tested-by as well - pruss/am33xx folks..? Further,
fyi, 6.12 collection cycle starts with 6.11 rc1 and I close mine around
rc4.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D