linux-kernel - Re: [PATCH 2/3] x86: Add basic support for the Congatec CGEB BIOS interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202407182128.dYt4Ud4g-lkp@intel.com>
Date: Thu, 18 Jul 2024 22:01:22 +0800
From: kernel test robot <lkp@...el.com>
To: Mary Strodl <mstrodl@....rit.edu>, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, akpm@...ux-foundation.org,
	urezki@...il.com, hch@...radead.org, linux-mm@...ck.org,
	lee@...nel.org, andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
	s.hauer@...gutronix.de, christian.gmeiner@...il.com,
	Mary Strodl <mstrodl@....rit.edu>
Subject: Re: [PATCH 2/3] x86: Add basic support for the Congatec CGEB BIOS
 interface

Hi Mary,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes akpm-mm/mm-everything andi-shyti/i2c/i2c-host linus/master v6.10 next-20240718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mary-Strodl/mm-vmalloc-export-__vmalloc_node_range/20240718-091816
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20240718011504.4106163-3-mstrodl%40csh.rit.edu
patch subject: [PATCH 2/3] x86: Add basic support for the Congatec CGEB BIOS interface
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240718/202407182128.dYt4Ud4g-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240718/202407182128.dYt4Ud4g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407182128.dYt4Ud4g-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/mfd/congatec-cgeb.c: In function 'cgeb_map_memory':
>> drivers/mfd/congatec-cgeb.c:360:52: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     360 |                                 ioremap_cache((u32)(resource_size_t)pmme->phys,
         |                                                    ^


vim +360 drivers/mfd/congatec-cgeb.c

   334	
   335	static int cgeb_map_memory(struct cgeb_board_data *board)
   336	{
   337		struct cgeb_map_mem_list *pmm;
   338		struct cgeb_map_mem *pmme;
   339		int i;
   340		int ret;
   341	
   342		ret = cgeb_call_simple(board, CgebMapGetMem, 0, (void *)&board->map_mem,
   343				NULL);
   344		if (ret)
   345			return ret;
   346		if (!board->map_mem)
   347			return 0;
   348	
   349		pmm = board->map_mem;
   350		pmme = pmm->entries;
   351	
   352		pr_debug("CGEB: Memory Map with %d entries\n", pmm->count);
   353	
   354		for (i = 0; i < pmm->count; i++, pmme++) {
   355			pr_debug("CGEB: Memory map entry phys=%px, size=%08x\n",
   356					pmme->phys, pmme->size);
   357			if (pmme->phys && pmme->size) {
   358				/* We only want to look at the lower 32 bits */
   359				pmme->virt.off =
 > 360					ioremap_cache((u32)(resource_size_t)pmme->phys,
   361						pmme->size);
   362				if (!pmme->virt.off)
   363					return -ENOMEM;
   364			 } else {
   365				pmme->virt.off = 0;
   366			}
   367	
   368			pmme->virt.seg = (pmme->virt.off) ? board->ds : 0;
   369	
   370			pr_debug("CGEB:   Map phys %p, size %08x, virt %04x:%p\n",
   371				pmme->phys, pmme->size, pmme->virt.seg,
   372				pmme->virt.off);
   373		}
   374	
   375		return cgeb_call_simple(board, CgebMapChanged, 0, NULL, NULL);
   376	}
   377	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki