linux-kernel - Re: [PATCH v7 2/4] iio: adc: ad7192: Update clock config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc1d58f9ca652dff81ffda0af2329cc673e888fb.camel@gmail.com>
Date: Thu, 18 Jul 2024 16:08:33 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Alisa-Dariana Roman <alisadariana@...il.com>, Alisa-Dariana Roman
 <alisa.roman@...log.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
 Michael Hennerich <michael.hennerich@...log.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Cc: Lars-Peter Clausen <lars@...afoo.de>, Jonathan Cameron
 <jic23@...nel.org>,  Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v7 2/4] iio: adc: ad7192: Update clock config

On Thu, 2024-07-18 at 00:25 +0300, Alisa-Dariana Roman wrote:
> There are actually 4 configuration modes of clock source for AD719X
> devices. Either a crystal can be attached externally between MCLK1 and
> MCLK2 pins, or an external CMOS-compatible clock can drive the MCLK2
> pin. The other 2 modes make use of the 4.92MHz internal clock.
> 
> Undocumented properties adi,int-clock-output-enable and adi,clock-xtal
> still supported for backward compatibility, but their use is highly
> discouraged. Use cleaner alternative of configuring external clock by
> using clock names mclk and xtal.
> 
> Functionality of AD7192_CLK_INT_CO will be implemented in complementary
> patch by adding clock provider.
> 
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
> ---

LGTM,

Reviewed-by: Nuno Sa <nuno.sa@...log.com>