linux-kernel - Re: [PATCH v2] mailbox: mtk-cmdq: Move devm_mbox_controller_register() after devm_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64f73196293dd86ce2f838b4d76616bcda14bd0e.camel@mediatek.com>
Date: Thu, 18 Jul 2024 14:12:58 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
	CK Hu (胡俊光) <ck.hu@...iatek.com>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "jaswinder.singh@...aro.org"
	<jaswinder.singh@...aro.org>
Subject: Re: [PATCH v2] mailbox: mtk-cmdq: Move
 devm_mbox_controller_register() after devm_pm_runtime_enable()

Hi Angelo,

Thanks for the reviews.

[snip]
> > ---
> >   drivers/mailbox/mtk-cmdq-mailbox.c | 14 ++++++++------
> >   1 file changed, 8 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> > b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index f1dfce9e27f5..002003c3970a 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -370,6 +370,8 @@ static void cmdq_remove(struct platform_device
> > *pdev)
> >   {
> >   	struct cmdq *cmdq = platform_get_drvdata(pdev);
> >   
> > +	devm_mbox_controller_unregister(&pdev->dev, &cmdq->mbox);
> 
> ...if you moved devm_mbox_controller_register() after
> devm_pm_runtime_enable(),
> this means that the teardown sequence will disable pm runtime after
> unregistering
> the mbox controller, so why do you need to call
> devm_mbox_controller_unregister()
> manually here?
> 

Since this is the first time I use b4 --manul-rerell to the v1 path, I
forgot to remove the change in v1.

I'll remove this and send v3 soon.

Regards,
Jason-JH.Lin


> Cheers,
> Angelo